From 01be6ce58185437596ce137784b6bdd0b001da9a Mon Sep 17 00:00:00 2001
From: Antoine Lambert <anlambert@softwareheritage.org>
Date: Thu, 29 Jun 2023 17:41:06 +0200
Subject: [PATCH] opam: Only capture stdout when calling 'opam list'

Ensure opam errors are displayed when attempting to list all packages
in order to ease debugging.

Related to swh/infra/sysadm-environment#4971.
---
 swh/lister/opam/lister.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/swh/lister/opam/lister.py b/swh/lister/opam/lister.py
index 5e56afe..dc3efec 100644
--- a/swh/lister/opam/lister.py
+++ b/swh/lister/opam/lister.py
@@ -6,7 +6,7 @@
 import logging
 import os
 import shutil
-from subprocess import run
+from subprocess import PIPE, run
 from typing import Any, Dict, Iterator, Optional
 
 from swh.lister.pattern import StatelessLister
@@ -97,7 +97,7 @@ class OpamLister(StatelessLister[PageType]):
                 "--short",
             ],
             env=self.env,
-            capture_output=True,
+            stdout=PIPE,
             text=True,
             check=True,
         )