From 264e9ea574da07216e12f0501f6e73530034029f Mon Sep 17 00:00:00 2001
From: David Douard <david.douard@sdfa3.org>
Date: Tue, 8 Jan 2019 10:27:11 +0100
Subject: [PATCH] Add tests for gitlab tasks

---
 swh/lister/core/tests/conftest.py     |   1 +
 swh/lister/gitlab/tasks.py            |   6 +-
 swh/lister/gitlab/tests/conftest.py   |   1 +
 swh/lister/gitlab/tests/test_tasks.py | 102 ++++++++++++++++++++++++++
 4 files changed, 108 insertions(+), 2 deletions(-)
 create mode 100644 swh/lister/gitlab/tests/conftest.py
 create mode 100644 swh/lister/gitlab/tests/test_tasks.py

diff --git a/swh/lister/core/tests/conftest.py b/swh/lister/core/tests/conftest.py
index f4a0e99..ce1039e 100644
--- a/swh/lister/core/tests/conftest.py
+++ b/swh/lister/core/tests/conftest.py
@@ -12,6 +12,7 @@ def celery_includes():
         'swh.lister.bitbucket.tasks',
         'swh.lister.debian.tasks',
         'swh.lister.github.tasks',
+        'swh.lister.gitlab.tasks',
     ]
 
 
diff --git a/swh/lister/gitlab/tasks.py b/swh/lister/gitlab/tasks.py
index eb8a4cb..7069a6e 100644
--- a/swh/lister/gitlab/tasks.py
+++ b/swh/lister/gitlab/tasks.py
@@ -54,9 +54,11 @@ def full_gitlab_relister(self, **lister_args):
     _, total_pages, _ = lister.get_pages_information()
     ranges = list(utils.split_range(total_pages, NBPAGES))
     random.shuffle(ranges)
-    group(range_gitlab_lister.s(minv, maxv, **lister_args)
-          for minv, maxv in ranges)()
+    promise = group(range_gitlab_lister.s(minv, maxv, **lister_args)
+                    for minv, maxv in ranges)()
     self.log.debug('%s OK (spawned %s subtasks)' % (self.name, len(ranges)))
+    promise.save()
+    return promise.id
 
 
 @app.task(name='swh.lister.gitlab.tasks.ping',
diff --git a/swh/lister/gitlab/tests/conftest.py b/swh/lister/gitlab/tests/conftest.py
new file mode 100644
index 0000000..507fef9
--- /dev/null
+++ b/swh/lister/gitlab/tests/conftest.py
@@ -0,0 +1 @@
+from swh.lister.core.tests.conftest import *  # noqa
diff --git a/swh/lister/gitlab/tests/test_tasks.py b/swh/lister/gitlab/tests/test_tasks.py
new file mode 100644
index 0000000..6438ca1
--- /dev/null
+++ b/swh/lister/gitlab/tests/test_tasks.py
@@ -0,0 +1,102 @@
+from time import sleep
+from celery.result import GroupResult
+
+from unittest.mock import patch
+
+
+def test_ping(swh_app, celery_session_worker):
+    res = swh_app.send_task(
+        'swh.lister.gitlab.tasks.ping')
+    assert res
+    res.wait()
+    assert res.successful()
+    assert res.result == 'OK'
+
+
+@patch('swh.lister.gitlab.tasks.GitLabLister')
+def test_incremental(lister, swh_app, celery_session_worker):
+    # setup the mocked GitlabLister
+    lister.return_value = lister
+    lister.run.return_value = None
+    lister.get_pages_information.return_value = (None, 10, None)
+
+    res = swh_app.send_task(
+        'swh.lister.gitlab.tasks.IncrementalGitLabLister')
+    assert res
+    res.wait()
+    assert res.successful()
+
+    lister.assert_called_once_with(
+        api_baseurl='https://gitlab.com/api/v4',
+        instance='gitlab', sort='desc', per_page=20)
+    lister.db_last_index.assert_not_called()
+    lister.get_pages_information.assert_called_once_with()
+    lister.run.assert_called_once_with(
+        min_bound=1, max_bound=10, check_existence=True)
+
+
+@patch('swh.lister.gitlab.tasks.GitLabLister')
+def test_range(lister, swh_app, celery_session_worker):
+    # setup the mocked GitlabLister
+    lister.return_value = lister
+    lister.run.return_value = None
+
+    res = swh_app.send_task(
+        'swh.lister.gitlab.tasks.RangeGitLabLister',
+        kwargs=dict(start=12, end=42))
+    assert res
+    res.wait()
+    assert res.successful()
+
+    lister.assert_called_once_with(
+        api_baseurl='https://gitlab.com/api/v4',
+        instance='gitlab', sort='asc', per_page=20)
+    lister.db_last_index.assert_not_called()
+    lister.run.assert_called_once_with(min_bound=12, max_bound=42)
+
+
+@patch('swh.lister.gitlab.tasks.GitLabLister')
+def test_relister(lister, swh_app, celery_session_worker):
+    # setup the mocked GitlabLister
+    lister.return_value = lister
+    lister.run.return_value = None
+    lister.get_pages_information.return_value = (None, 85, None)
+    lister.db_partition_indices.return_value = [
+        (i, i+9) for i in range(0, 80, 10)] + [(80, 85)]
+
+    res = swh_app.send_task(
+        'swh.lister.gitlab.tasks.FullGitLabRelister')
+    assert res
+
+    res.wait()
+    assert res.successful()
+
+    # retrieve the GroupResult for this task and wait for all the subtasks
+    # to complete
+    promise_id = res.result
+    assert promise_id
+    promise = GroupResult.restore(promise_id, app=swh_app)
+    for i in range(5):
+        if promise.ready():
+            break
+        sleep(1)
+
+    lister.assert_called_with(
+        api_baseurl='https://gitlab.com/api/v4',
+        instance='gitlab', sort='asc', per_page=20)
+
+    # one by the FullGitlabRelister task
+    # + 9 for the RangeGitlabLister subtasks
+    assert lister.call_count == 10
+
+    lister.db_last_index.assert_not_called()
+    lister.db_partition_indices.assert_not_called()
+    lister.get_pages_information.assert_called_once_with()
+
+    # lister.run should have been called once per partition interval
+    for i in range(8):
+        # XXX inconsistent behavior: max_bound is EXCLUDED here
+        assert (dict(min_bound=10*i, max_bound=10*i + 10),) \
+            in lister.run.call_args_list
+    assert (dict(min_bound=80, max_bound=85),) \
+        in lister.run.call_args_list