reonokiy/swh-lister
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lister/tasks: Standardize return statements

Browse source 
The following commit adapts the return statements from both lister and their
associated tasks. This standardizes on what other modules (e.g. both dvcs and
package loaders) do.
This commit is contained in:
Antoine R. Dumont (@ardumont) 2019-12-02 15:49:38 +01:00
parent ff7fdf24db
commit 4a9608f31c
No known key found for this signature in database
GPG key ID: 52E2E9840D10C3B8
15 changed files with 42 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

5
swh/lister/github/tasks.py
View file

@ -15,13 +15,13 @@ GROUP_SPLIT = 10000
def list_github_incremental(**lister_args):
'Incremental update of GitHub'
lister = GitHubLister(**lister_args)
lister.run(min_bound=lister.db_last_index(), max_bound=None)
return lister.run(min_bound=lister.db_last_index(), max_bound=None)
@shared_task(name=__name__ + '.RangeGitHubLister')
def _range_github_lister(start, end, **lister_args):
lister = GitHubLister(**lister_args)
lister.run(min_bound=start, max_bound=end)
return lister.run(min_bound=start, max_bound=end)
@shared_task(name=__name__ + '.FullGitHubRelister', bind=True)
@ -44,6 +44,7 @@ def list_github_full(self, split=None, **lister_args):
promise.save() # so that we can restore the GroupResult in tests
except (NotImplementedError, AttributeError):
self.log.info('Unable to call save_group with current result backend.')
# FIXME: what to do in terms of return here?
return promise.id