reonokiy/swh-lister
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tests: Separate lister instantiations

Browse source 
Prior to this commit, all listers were instantiated at the same time even if
only one was needed. This commit separates those instantiations.

The only drawback to this is the db model initialization which now happens at
each lister instantiation. This can be dealt with if needed at another time
though.
This commit is contained in:
Antoine R. Dumont (@ardumont) 2020-09-02 09:47:12 +02:00
parent 92422dcf75
commit 5a5b7ef70b
No known key found for this signature in database
GPG key ID: 52E2E9840D10C3B8
14 changed files with 127 additions and 87 deletions
Download patch file Download diff file Expand all files Collapse all files

16
swh/lister/gitlab/tests/test_lister.py
View file

@ -1,4 +1,4 @@
# Copyright (C) 2017-2019 The Software Heritage developers
# Copyright (C) 2017-2020 The Software Heritage developers
# See the AUTHORS file at the top-level directory of this distribution
# License: GNU General Public License version 3, or any later version
# See top-level LICENSE file for more information
@ -6,8 +6,11 @@
import logging
import re
import unittest
from datetime import datetime, timedelta
import pytest
from swh.lister.core.tests.test_lister import HttpListerTesterBase
from swh.lister.gitlab.lister import GitLabLister
@ -43,12 +46,15 @@ class GitLabListerTester(HttpListerTesterBase, unittest.TestCase):
return '{"error":"dummy"}'
def test_lister_gitlab(swh_listers, requests_mock_datadir):
lister = swh_listers["gitlab"]
@pytest.fixture
def lister_under_test():
return "gitlab"
lister.run()
r = lister.scheduler.search_tasks(task_type="load-git")
def test_lister_gitlab(swh_lister, requests_mock_datadir):
swh_lister.run()
r = swh_lister.scheduler.search_tasks(task_type="load-git")
assert len(r) == 10
for row in r: