reonokiy/swh-lister
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

phabricator: small refactoring/simplification of the request_params method

Browse source 
and get rid of the unneeded _build_query_params method.
This commit is contained in:
David Douard 2019-08-30 10:27:40 +02:00
parent 83d138759c
commit 814779404c
1 changed files with 3 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

16
swh/lister/phabricator/lister.py
View file

@ -37,16 +37,6 @@ class PhabricatorLister(IndexingHttpLister):
"""
return self._bootstrap_repositories_listing()
def _build_query_params(self, params, api_token):
"""Build query params to include the forge's api token
Returns:
updated params dict with 'params' entry.
"""
params.update({'params': {'api.token': api_token}})
return params
def request_params(self, identifier):
"""Override the default params behavior to retrieve the api token
@ -59,14 +49,14 @@ class PhabricatorLister(IndexingHttpLister):
password: <api-token>
"""
params = {}
params['headers'] = self.request_headers() or {}
instance_creds = self.request_instance_credentials()
if not instance_creds:
raise ValueError(
'Phabricator forge needs authentication credential to list.')
api_token = instance_creds[0]['password']
return self._build_query_params(params, api_token)
return {'headers': self.request_headers() or {},
'params': {'api.token': api_token}}
def request_headers(self):
"""