reonokiy/swh-lister
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

debian: refactor inner loop slightly to help mypy

Browse source 
mypy doesn't catch that multiple uses of
`self.listed_origins[origin_url]` in the same statement should be identical.
Using a temporary local variable for it seems to help.
This commit is contained in:
Nicolas Dandrimont 2023-06-21 13:57:27 +02:00
parent 0e7fdf482c
commit b2ff630c9b
1 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
swh/lister/debian/lister.py
View file

@ -232,11 +232,13 @@ class DebianLister(Lister[DebianListerState, DebianPageType]):
self.package_versions[package_name] = set()
# origin will be yielded at the end of that method
origins_to_send[origin_url] = self.listed_origins[origin_url]
current_origin = origins_to_send[origin_url] = self.listed_origins[
origin_url
]
# update package versions data in parameter that will be provided
# to the debian loader
self.listed_origins[origin_url].extra_loader_arguments["packages"].update(
current_origin.extra_loader_arguments["packages"].update(
{
package_version_key: {
"name": package_name,
@ -246,14 +248,13 @@ class DebianLister(Lister[DebianListerState, DebianPageType]):
}
)
if self.listed_origins[origin_url].last_update is None or (
if current_origin.last_update is None or (
self.last_sources_update is not None
and self.last_sources_update # type: ignore
> self.listed_origins[origin_url].last_update
and self.last_sources_update > current_origin.last_update
):
# update debian package last update if current processed sources index
# has a greater modification date
self.listed_origins[origin_url].last_update = self.last_sources_update
current_origin.last_update = self.last_sources_update
# add package version key to the set of found versions
self.package_versions[package_name].add(package_version_key)