reonokiy/swh-lister
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

phabricator.tasks: Remove unused code

Browse source 
Related T1824
Related P438
This commit is contained in:
Antoine R. Dumont (@ardumont) 2019-06-18 14:12:55 +02:00
parent af681ac128
commit df2754e5a6
No known key found for this signature in database
GPG key ID: 52E2E9840D10C3B8
2 changed files with 0 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

6
swh/lister/phabricator/tasks.py
View file

@ -12,12 +12,6 @@ def new_lister(forge_url='https://forge.softwareheritage.org', instance='swh',
forge_url=forge_url, instance=instance, api_token=api_token, **kw)
@app.task(name=__name__ + '.IncrementalPhabricatorLister')
def incremental_phabricator_lister(**lister_args):
lister = new_lister(**lister_args)
lister.run(min_bound=lister.db_last_index())
@app.task(name=__name__ + '.FullPhabricatorLister')
def full_phabricator_lister(**lister_args):
lister = new_lister(**lister_args)

22
swh/lister/phabricator/tests/test_tasks.py
View file

@ -1,5 +1,3 @@
from unittest.mock import patch
def test_ping(swh_app, celery_session_worker):
res = swh_app.send_task(
@ -8,23 +6,3 @@ def test_ping(swh_app, celery_session_worker):
res.wait()
assert res.successful()
assert res.result == 'OK'
@patch('swh.lister.phabricator.tasks.PhabricatorLister')
def test_incremental(lister, swh_app, celery_session_worker):
# setup the mocked PhabricatorLister
lister.return_value = lister
lister.db_last_index.return_value = 42
lister.run.return_value = None
res = swh_app.send_task(
'swh.lister.phabricator.tasks.IncrementalPhabricatorLister')
assert res
res.wait()
assert res.successful()
lister.assert_called_once_with(
api_token=None, forge_url='https://forge.softwareheritage.org',
instance='swh')
lister.db_last_index.assert_called_once_with()
lister.run.assert_called_once_with(min_bound=42)