reonokiy/swh-lister
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gitlab.lister: Simplify retrieving headers information

Browse source 
As response headers' keys are case-insensitive and requests does the
aggregation magic.

[1] http://docs.python-requests.org/en/master/user/quickstart/#response-headers
This commit is contained in:
Antoine R. Dumont (@ardumont) 2018-07-16 13:57:34 +02:00
parent ec6968e31a
commit e24cf1d4f1
No known key found for this signature in database
GPG key ID: 52E2E9840D10C3B8
3 changed files with 9 additions and 63 deletions
Download patch file Download diff file Expand all files Collapse all files

39
swh/lister/tests/test_utils.py
View file

@ -11,45 +11,6 @@ from swh.lister import utils
class UtilsTest(unittest.TestCase):
@istest
def get(self):
data = {
'X-Next-Page': None,
'x-next-page': 1,
}
actual_value = utils.get(data, ['X-Next-Page', 'x-next-page'])
self.assertEqual(actual_value, 1)
data = {
'X-Next-Page': 10,
'x-next-page': 1,
}
actual_value = utils.get(data, ['X-Next-Page', 'x-next-page'])
self.assertEqual(actual_value, 10)
data = {
'x-next-page': 100,
}
actual_value = utils.get(data, ['X-Next-Page', 'x-next-page'])
self.assertEqual(actual_value, 100)
@istest
def get_empty(self):
self.assertIsNone(utils.get({}, []))
self.assertIsNone(utils.get({'a': 1}, ['b']))
self.assertIsNone(utils.get({'b': 2}, []))
self.assertIsNone(utils.get({'b': 2}, []))
@istest
def get_errors(self):
with self.assertRaises(TypeError):
self.assertIsNone(utils.get({}, None))
with self.assertRaises(AttributeError):
self.assertIsNone(utils.get(None, ['a']))
@istest
def split_range(self):
actual_ranges = list(utils.split_range(14, 5))